Cleanup banking bench (backport #24851) #24917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
added
automerge
|
automerge label removed due to a CI failure |
yhchiang-sol
suggested changes
May 3, 2022
* Cleanup banking bench * Fully remove assert
carllin
force-pushed
the
mergify/bp/v1.10/pr-24851
branch
from
24b8ede to
3ebe35f
Compare
mergify
bot
added
the
automerge
|
@yhchiang-sol yup, was blocked on backporting #24919. Now that's merged thanks to @taozhu-chicago, this should be a clean merge! |
|
automerge label removed due to a CI failure |
mergify
bot
added
automerge
Codecov Report
@@ Coverage Diff @@
## v1.10 #24917 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 588 588
Lines 160624 160624
=========================================
- Hits 131002 130925 -77
- Misses 29622 29699 +77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #24851 done by Mergify.
Cherry-pick of e83efe6 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com